Enable CA1822 (Mark members as static) analyzer #66333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
stephentoub
reviewed
Mar 8, 2022
src/coreclr/nativeaot/Runtime.Base/src/System/AttributeUsageAttribute.cs
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/SspiCli/SafeDeleteContext.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/SspiCli/SecuritySafeHandles.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.DataContractSerialization/src/System/Xml/XmlBinaryWriter.cs
Show resolved
Hide resolved
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Compilation.cs
Outdated
Show resolved
Hide resolved
| public void TraceNode(QilNode n) | ||
| { | ||
| #if QIL_TRACE_NODE_CREATION | ||
| this.diag.AddNode(n); | ||
| #endif | ||
| } | ||
| #pragma warning restore CA1822 |
There was a problem hiding this comment.
@krwq, is any of this tracing stuff ever used? Wondering if we can just delete it all instead.
...s/System.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/MetadataBuilder.Heaps.cs
Outdated
Show resolved
Hide resolved
...ation.Formatters/src/System/Runtime/Serialization/Formatters/Binary/BinaryFormatterWriter.cs
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/System.Private.CoreLib/src/System/Array.CoreRT.cs
Outdated
Show resolved
Hide resolved
marek-safar
force-pushed
the
CA1822
branch
17 times, most recently
from
dcf6f93 to
2c165a0
Compare
stephentoub
reviewed
Mar 24, 2022
src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeStream.Unix.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 24, 2022
stephentoub
reviewed
Mar 24, 2022
...DataContractSerialization/src/System/Runtime/Serialization/Json/JsonFormatWriterGenerator.cs
Show resolved
Hide resolved
Tratcher
reviewed
Mar 24, 2022
| @@ -710,15 +710,15 @@ private void OnIndexedHeaderName(int index) | |||
| _state = State.HeaderValueLength; | |||
| } | |||
|
|
|||
| private void OnIndexedHeaderNamePostBase(int index) | |||
| private static void OnIndexedHeaderNamePostBase(int index) | |||
There was a problem hiding this comment.
These won't be static once they're actually implemented.
There was a problem hiding this comment.
I think that's fine, one you implemented them you remove static
stephentoub
reviewed
Mar 24, 2022
| @@ -10,9 +10,9 @@ internal sealed class DefaultSettingsSection // ConfigurationSection | |||
|
|
|||
| internal static DefaultSettingsSection GetSection() => s_section; | |||
|
|
|||
| public string DistributedTransactionManagerName { get; set; } = ConfigurationStrings.DefaultDistributedTransactionManagerName; | |||
| public static string DistributedTransactionManagerName { get; set; } = ConfigurationStrings.DefaultDistributedTransactionManagerName; | |||
There was a problem hiding this comment.
@roji should weigh in on whether any of these changes are going to conflict with his work.
stephentoub
reviewed
Mar 24, 2022
| @@ -710,15 +710,15 @@ private void OnIndexedHeaderName(int index) | |||
| _state = State.HeaderValueLength; | |||
| } | |||
|
|
|||
| private void OnIndexedHeaderNamePostBase(int index) | |||
| private static void OnIndexedHeaderNamePostBase(int index) | |||
There was a problem hiding this comment.
I believe this file is mirrored with aspnetcore. It'd be good to validate whether it's going to break anything when that happens.
There was a problem hiding this comment.
I believe this should be fine as it's private and aspnetcore already had them static (they have CS1822 enabled) before sync with runtime removed it.
stephentoub
approved these changes
Mar 24, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
ghost
locked as resolved and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.